nus-cs2113-AY2122S2 / pe-dev-response

0 stars 0 forks source link

White spaces allowed in timing #838

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Perhaps white spaces should be removed when entered in timing

image.png


[original: nus-cs2113-AY2122S2/pe-interim#1020] [original labels: severity.Low type.FeatureFlaw]

mathanmahe commented 2 years ago

Team's Response

This is not a bug and an intended feature.

We only require the timing to follow the overall format as mentioned in the UG.

HH:MM am/pm - HH:MM am/pm

However we are not strict in checking for additional white spaces. We have consciously allowed extra white spaces as it would otherwise count as over zealous input validation.

Therefore the user input is valid as it obeys the format, despite the white spaces that are ignored.

We still believe this is a fair input validation as it checks for overall required format and optionally allows extra white spaces.

Duplicate status (if any):

--