nus-cs2113-AY2223S1 / forum

4 stars 0 forks source link

Level-6 Jar file #18

Open Franky4566 opened 2 years ago

Franky4566 commented 2 years ago

hi prof! sorry may I also my friend and I did not realise we needed to create a release for the ip week 6 jar file (Week-6-Jar). However, we uploaded our jar file during the time frame but created a release after the time frame. Would we still be penalised for this task?

okkhoy commented 2 years ago

How did you upload the JAR without creating a release? If the dashboard shows green, nothing to worry.

JordanKwua commented 2 years ago

Hello prof, I am the friend mentioned in this thread. Instead of creating a release to upload the JAR file in Week 6, I pushed the JAR file into my repository instead. I pushed it on time but since it was not created as a release it still remains as red, what could I do to resolve this issue?

okkhoy commented 2 years ago

hmmm no no.. pushing JAR doesn't count. Pl. create a release and upload the JAR. Pl. do so by tomorrow so that we get the correct file for evaluation.

JordanKwua commented 2 years ago

Prof I have released the Week 6 JAR and tagged it as v0.1. However, the source code attached with the JAR is the latest version in my repository. Do I have to make sure the source code reflects the code I had when I built Week 6 JAR and pushed it?

okkhoy commented 2 years ago

no need; current state is OK