okkhoy
commented
1 year ago We don't mandate setting up branch protection rules. You can set it up by specifying the rules that you see fit. More details on the rules and how to go about it:
- https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches
- https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule
Can I know if this is the correct way to protect the PR from being merged in the master branch? I saw that there are no steps in the course website that told us to specify the required rules. The PR is allowed to merge despite failing the CI. So I fixed the configuration to this. Is it needed to configure it that way?