search

nus-cs2113-AY2223S1 / forum

4 stars 0 forks source link

IO Redirection test failure on CI/CD #27

Open kyrenechua opened 2 years ago

kyrenechua commented 2 years ago

My team is running into issues with the Github Actions checks when making/merging pull requests. Specifically, IO Redirection is causing us issues - this is due to our error handling printing out filepaths. Since Paths.toString() uses the system-dependent name separator, the EXPECTED.txt is bound to not match with the ACTUAL.txt on either Mac/Linux or Windows. (See https://github.com/AY2223S1-CS2113-T17-4/tp/pull/47/checks - the Windows gradle test fail is unrelated and has been fixed)

While we can remove the printing of filepaths, we feel this is a feature that improves user experience and helps users troubleshoot errors, and removing it for the sake of passing a test is counterintuitive to the project as a whole. Are there any ways we can make this test pass (or suppress the test for those lines) without removing functionality?

okkhoy commented 2 years ago

Since you are focusing on JUnit tests, you can choose to totally skip i/o redirection tests. I think I mentioned this in the lecture.