nus-cs2113-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Lack of Exceptions Used #757

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


Looking through the documentation I found that most of the errors were handled within each command class itself rather than a erroneous input or error throwing an exception that can be handled.


[original: nus-cs2113-AY2223S1/pe-interim#733] [original labels: severity.VeryLow type.DocumentationBug]

owenl131 commented 1 year ago

Team's Response

Exceptions should be used when issues need to be propagated back to the caller(s). In the case of commands, since each command has clear knowledge of the error condition and how to fix it, it is in a better position to handle the issues than propagate them to the caller(s). Furthermore, exceptions break normal program flow and should be used with care.

Duplicate status (if any):

--