nus-cs2113-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Should set a limit for ridiculous budget values perhaps #837

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

image.png Would be a good idea to limit the value of the budget in my opinion


[original: nus-cs2113-AY2223S1/pe-interim#879] [original labels: type.FeatureFlaw severity.Medium]

OVReader commented 1 year ago

Team's Response

Yes, indeed it is not logical to have such a high values but considering the rarity of having such high value for budget, the severity should be low instead.

However, this feature (budget limit validation which is of lower priority) is not related to features delivered in v2.1. In v2.1 for add -property feature, the main focus lies on the validation between mismatched address format and unit type of property which took a lot of time to research (15 unit types) and implement. Thus, this valid bug shall be categorized as NotInScope as stated in the picture below.

image.png

Furthermore, the current budget feature works as intented.

Duplicate status (if any):

--