Exchanging a currency of higher value to lower value fails but STILL deducts currency if the converted value exceeds the limit of 10000000

[nus-pe-bot]

Exchange a currency of higher value to lower value fails but STILL deducts currency if the converted value exceeds the limit of 10000000. For example, when converting 10000000sgd to jpy, where 1sgd = 100jpy, the program tells you you are unable to store more than 10000000 of any given currency, which is fair. However, the amount is still deducted from the account, resulting in a loss of money.

The bug is shown in the image below

Steps to reproduce

1. add 10000000 of any high value currency
2. exchange 10000000 of that currency for a lower value currency

expected outcome The transaction should fail as the converted amount exceeds the account cap, but no money shld be deducted from the original account

Actual outcome All the money is still deducted from the account

image of bug

---

_{[original: nus-cs2113-AY2223S2/pe-interim#1880] [original labels: type.FunctionalityBug severity.High]}

[woowenjun99]

Team's Response

Accepted but changed severity to medium as this bug does not make the application unusable.

Duplicate status (if any):

--