nus-cs2113-AY2223S2 / pe-dev-response

0 stars 0 forks source link

bug: same name restriction for additem can be circumvented by modifying json file #1458

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Same name restriction for additem can be circumvented by modifying json file

Steps to reproduce:

Edit the menu json file to have multiple items with the same name

Expected output:

Error handling with storage resetting

Actual output:

image.png


[original: nus-cs2113-AY2223S2/pe-interim#1986] [original labels: type.FunctionalityBug severity.Low]

chungnicholas commented 1 year ago

Team's Response

This is achieved through malicious tampering of our data files.

While there are constraints of requiring data to be stored locally and that they should be in a human editable text file, there are no constraints in the tp that require us to check for the integrity of the file that has been intentionally broken by a professional user (such as you).

The target audience of our application is made up of mostly non-tech savvy people, and the only people who would tamper with such data files are developers. With that in mind, we did not prioritize integrity checking as we'd rather focus on implementing the other parts of our application.

With that being said, it is a good function, but not necessary to have. Perhaps in future iterations of the product, this feature could be implemented.

Duplicate status (if any):

Duplicate of #2762