search

nus-cs2113-AY2223S2 / pe-dev-response

0 stars 0 forks source link

Recipe random can choose a recipe that contains allergens #1498

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

The purpose of this feature is to recommend users random recipes to try. However this does not take into account the allergens that the user has input. This results in recipes recommended that could contain allergens, thus the recipes are not actually feasible for the user to use.

It is possible that none of the recipes are feasible for the user, but recipe random command will only keep throwing warnings and state that the next random recipe MIGHT not contain the allergen.

Tried random recipes 4 times with egg as an allergen, 3 of the recipes recommended contains egg and a warning prompt.

image.png

image.png

[original: nus-cs2113-AY2223S2/pe-interim#1176] [original labels: severity.Medium type.FeatureFlaw]

Jjzeng123 commented 1 year ago

Team's Response

This is not a bug. The UG clearly states that recipes containing allergen can be generated. image.png

Furthermore, the user would have read the warning in the output and know of the allergens in the recipe.

image.png

This is not a feature flaw either. It is not accurate to state that "The purpose of this feature is to recommend users random recipes to try" and "recipes are not actually feasible for the user to use". This design choice for recipe random to include recipes with allergen is done on purpose as it is meant to be a feature that focuses solely on the "random" aspect. Even a recipe that contains the user's allergen may be useful if the user is cooking for his/her friends in the hostel. There are definitely many other use cases for recipes with allergens as it is not uncommon for a person to cook for others especially since our target audience lives in a communal setting - hostels. A variant of random recipe that excludes recipes with allergen could be included in future versions although it is not in our plans yet.

"Tried random recipes 4 times with egg as an allergen, 3 of the recipes recommended contains egg and a warning prompt." is a rather biased comment when taken out of context. Our app has 7 default recipes, of which 3 of them contain egg. The probability of getting a recipe containing egg 3 times out of 4 attempt is not low at all. This observation is actually in-line with our design-goal of being completely random as mentioned earlier.

Duplicate status (if any):

Duplicate of #1650