nus-cs2113-AY2223S2 / pe-dev-response

0 stars 0 forks source link

Able to add invalid modules even though they were not listed in NUSMods #1539

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

image.png

It is stated to check NUSMods to ensure that the module is valid before adding. But I am still able to add the invalid mod even though it is not listed in NUSMods.

Perhaps it would be better if there is a basic list of all the mods stored locally so the application can do a simple cross check with the list?

Justification: This does not affect my usage of the application. Hence it is listed as low severity.


[original: nus-cs2113-AY2223S2/pe-interim#1206] [original labels: type.FunctionalityBug severity.Low]

Thiolk commented 1 year ago

Team's Response

According to the CS2113/T requirements, we are not able to store a database of modules and hence cannot check that if the module is actually valid and exists. Hence, our team has already done its best by limiting the number of characters that the user can input for module code to be 6-10 as valid modules are only of that certain length.

Duplicate status (if any):

Duplicate of #2028