nus-cs2113-AY2223S2 / pe-dev-response

0 stars 0 forks source link

Breaking Constraint-Single-User #293

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

image.png

This application allows the login of multiple different users at different times.

According to Contraint-Single-User in the CS2113 Website

The product should be for a single user i.e. (not a multi-user product).
Not allowed: Application running in a shared computer and different people using it at different times.
Not allowed: The data file created by one user being accessed by another user during regular operations (e.g., through a shared file storage mechanism).

This is breaking both the rules. The application can run in a shared computer and different people use at different times through the login system.

The data file created by one user can be accessed by another user during regular operations

image.png

As shown by this image, the data file is accessible by all the users during regular operations


[original: nus-cs2113-AY2223S2/pe-interim#381] [original labels: severity.High type.FeatureFlaw]

Brennanzuz commented 1 year ago

Team's Response

We accept that this is not allowed in the module guidelines due to misunderstanding. However, we have streamlined the project scope to be about diagnosing patients in a public setting with many users, with an emphasis on different users in different cases for their different symptoms. We do not accept it as a high severity as this issue does not affect the overall use of the software at all. Furthermore, the reasoning given for constraint-single-user is that it makes the product hard to test, as shown below. Since we have streamlined our registration and login processes, DrDuke is not hard to test despite it breaching the constraints set.

image.png

Furthermore, users should not be denied access to files on their computer, but they should not be tampering with the files that make it work, just as how complaints about software crashing caused by tampering with the source code are invalid.

Duplicate status (if any):

--