search

nus-cs2113-AY2223S2 / pe-dev-response

0 stars 0 forks source link

DG: Magic String in code #431

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

There shouldn't be magic int index =1

Rather, it should be int index = START_SERIAL_INDEX or something similar

image.png

More magic delimiters ^

[original: nus-cs2113-AY2223S2/pe-interim#570] [original labels: severity.Low type.DocumentationBug]

darrenangwx commented 1 year ago

Team's Response

This issue is same as issue #600.

This issue is talking about the Code Quality rather than the quality of documentation as it mentions about usage of Magic Literals in the code. Hence, our team decided to reject this bug.

Duplicate status (if any):

Duplicate of #600