nus-cs2113-AY2324S1 / forum

0 stars 0 forks source link

What if the tester maliciously edit the data file and report it as a bug? #53

Closed ziyi105 closed 10 months ago

ziyi105 commented 10 months ago

How can the developers proof innocent in this case?

okkhoy commented 10 months ago

Following this https://nus-cs2113-ay2324s1.github.io/website/admin/tp-constraints.html#constraint-human-editable-file it is a valid usecase.

ziyi105 commented 10 months ago

Noted! But if the tester edit it on purpose such that it affects the output, how can the developers prove innocence?

okkhoy commented 10 months ago

You need to handle that when you are loading the data file.

ziyi105 commented 10 months ago

If the tester add something in the data text file with correct formatting (e.g., add a new book A) after he exists the session, he restarts the application and list out a list of books which now contains bookA, and he reports it as a bug claiming that he didn't add book A in the previous session. Is this scenario possible and do we need to handle that?

okkhoy commented 10 months ago

😮 this can't be a bug.

If the file is corrupted, you need to handle it.

If the file contains valid data and you are using it as a part of the data to load and show, it is the correct use case. It can't be called a bug when the product is handling new data correctly.

ziyi105 commented 10 months ago

I see, thanks for the clarification prof!