nus-cs2113-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Adding activities with distance=0 should not be allowed from a logical perspective. #1021

Open nus-pe-bot opened 11 months ago

nus-pe-bot commented 11 months ago

Run the following command:\ add-activity Morning Run duration/01:00:00 distance/0 datetime/2021-09-01 06:00

Expected behavior: Although consistent with the UG, it's only logical that distance values should be strictly positive.

Actual behavior: Activity added with success message

Screenshot 2023-11-17 at 16.36.02.png


[original: nus-cs2113-AY2324S1/pe-interim#995] [original labels: severity.Low type.FeatureFlaw]

DaDevChia commented 11 months ago

Team's Response

Allowing a zero distance value is an intended design choice to provide flexibility in data entry. For instance, an activity entry might sometimes be used to log an exercise session that didn't involve actual running, such as stretching or warm-up exercises or popular gym workouts, where distance or even time is not applicable.

The current version of our software (with no specific features for stationary gym workouts) with this flexibility therefore allows the user to use the software in different ways.

Rejection of zero inputs would rather annoy users who want to track a gym workout but not increase the distance counter. Therefore this is not in scope.

Duplicate status (if any):

--