nus-cs2113-AY2324S1 / pe-dev-response

0 stars 0 forks source link

[Edit Recipe] App crashes when running edit command with valid input #1044

Open nus-pe-bot opened 12 months ago

nus-pe-bot commented 12 months ago

Description

App crashes when running the edit r command with valid input. In this case, I tried to change the recipe's first step to add 1/4 tblspoon of water and it crashed. Considering that it is common for recipes to have figures like 1/4, the app would likely crash frequently when the user runs the edit r command, hence the High severity given.

Steps to Reproduce

  1. Run the app
  2. Add the following recipe by running add r/scramble egg t/1 s/buy ingredients t/2 s/wash ingredients s/bake ingredients i/egg,2,pc
  3. Edit the recipe's first step by running edit r/scramble egg s/1,add 1/4 tblspoon of water
  4. The app will crash

Actual Output

When performing step 3 as mentioned above, the app will crash.

image.png

Expected Output

The app should not crash and the recipe's first step should be successfully edited.


[original: nus-cs2113-AY2324S1/pe-interim#1025] [original labels: type.FunctionalityBug severity.High]

kaijie0102 commented 11 months ago

Team's Response

We accept that it is a bug where special characters are not handled.

However, (a) we believe that it is a feature flaw and not a functionality flaw because

(b) Severity should be medium, because

Duplicate status (if any):

--