search

nus-cs2113-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Error handling for numbers include Java exceptions #890

Open nus-pe-bot opened 9 months ago

nus-pe-bot commented 9 months ago

upon wrong number of calories given, the seedu.duke.data.exception.IncorrectFormatException will also appear

steps to reproduce:

log 1 2 Football 9999999999999

log 1 2 Football -1000

expected:

Please specify reasonable positive numbers in the month, day, and calories burned fields

You cannot burn a negative number of calories.

actual:

seedu.duke.data.exception.IncorrectFormatException: Please specify reasonable positive numbers in the month, day, and calories burned fields

seedu.duke.data.exception.IncorrectFormatException: You cannot burn a negative number of calories.

image.png

[original: nus-cs2113-AY2324S1/pe-interim#797] [original labels: type.FeatureFlaw severity.VeryLow]

Remy9926 commented 9 months ago

Team's Response

Thank you for spotting this error. We should have been more careful in the testing phase when testing these kinds of outputs and seeing what the program outputs. We have put this error as a severity.VeryLow as it is purely a UI issue.

Duplicate status (if any):

--