nus-cs2113-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Invalid Budget but succeeded #993

Open nus-pe-bot opened 12 months ago

nus-pe-bot commented 12 months ago

When the user gives the input "Budget 123d", it means that they typed an additional "d" by mistake, but this works, however, I think you have to return an error message for it instead.

Screenshot 2023-11-17 at 16.35.35.png


[original: nus-cs2113-AY2324S1/pe-interim#949] [original labels: type.FunctionalityBug severity.Low]

lckjosh commented 12 months ago

Team's Response

Thanks for your input. However, our error message shows that the budget amount requires a +ve valid float value.

According to the official java documentation here: https://docs.oracle.com/javase/specs/jls/se11/html/jls-3.html#jls-3.10.2

The 'd' character is accepted as a suffix of a float value. Thus we consider this not a bug as '123d' is indeed considered a float value.

Duplicate status (if any):

--