nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Rounding of cost values when adding items #1459

Open nus-pe-bot opened 4 months ago

nus-pe-bot commented 4 months ago

The application rounds the cost of items to the nearest 2 decimal places when adding an item, which might not be what the user intended as the user might not want any rounding or might want to always round down instead of rounding to nearest 2 decimal places. There is also no parameter to configure how the application rounds the cost

image.png


[original: nus-cs2113-AY2324S2/pe-interim#1307] [original labels: severity.Low type.FeatureFlaw]

YHWong20 commented 4 months ago

Team's Response

Your justification is fair and totally valid.

With respect to the rounding to 2 d.p., we are simply abiding by the currency denomination standard adopted in most countries.

However, the option to round down/up should be offered to the user (as this rounding standard varies, depending on the country). We accept that this is a flaw of our price parsing capabilities.

Duplicate status (if any):

--