search

nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

DG Workout UML Run class #1519

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

Missing attributes: date, isHourPresent.

All the attributes are protected, and hence must be represented by a "#".

method, splitRunTime() is missing form diagram. Does not have to be a part of the utility package?

[original: nus-cs2113-AY2324S2/pe-interim#1808] [original labels: severity.Low type.DocumentationBug]

rouvinerh commented 2 months ago

Team's Response

Attributes are private based on latest Github release. isHourPresent is no longer an attribute part of Run. Not all methods are mentioned in class diagram intentionally as it will make the diagram too big and complex. Our TA mentioned only important methods should be mentioned, since developers can read the code themselves.

Duplicate status (if any):

--