nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

No notification when item still lies below threshold after restocking #1653

Open nus-se-script opened 6 months ago

nus-se-script commented 6 months ago

The user is not notified that an item's quantity is still below the threshold after restocking despite there being such a notification if the item's quantity falls below the threshold after selling which is inconsistent behaviour.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#1460] [original labels: severity.Low type.FeatureFlaw]

YHWong20 commented 6 months ago

Team's Response

Duplicate of #1793.

Likewise, we believe that this issue poses a minor inconvenience for users.

Assuming a normal, logical flow of events for the business - suppose the user tried to sell off 3 of the pear item.

In this case, they will now definitely receive the notification that informs them of falling stock levels, as the sell command recognizes that stock levels have fallen below the threshold.

We believe that under normal/expected usage, the user will still receive the notification, albeit delayed. We accept that this delayed notification will pose a minor inconvenience, and thus, it is a feature flaw with low severity.

Duplicate status (if any):

Duplicate of #1793