nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Incorrect UML diagram #1718

Open nus-pe-bot opened 5 months ago

nus-pe-bot commented 5 months ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


Screenshot 2024-04-19 at 5.44.14 PM.png

If Argument List is not being used after "return parsedArguments", the rectangle for :ArgumentList do not need to stretch to the end. It can end off after parsedArguments is return.

From the Usage scenario of ModifyCommand


[original: nus-cs2113-AY2324S2/pe-interim#1527] [original labels: severity.Low type.DocumentationBug]

T0nyLin commented 5 months ago

Team's Response

Thank you for pointing this out. It is indeed an issue that the activation bar should have been closed at return parsedArguments. This issue is a duplicate of #919 as they both raised the same issue with the activation bar closing too late and should have been closed earlier at return parsedArguments.

Duplicate status (if any):

Duplicate of #919