search

nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Should not be able to add modules that requires pre-req before I have done the pre-req #1937

Open nus-se-script opened 5 months ago

nus-se-script commented 5 months ago

Description: I should not be able to add a 2k module before having done the 1k module. E.g. adding in CS1101s after adding in CS2040C

Steps to Reproduce:

  1. Launch the app
  2. `add c\CS1101s w\4
  3. add c\CS2040C w\1

Expected Result: It should have prompted me with an error telling me that CS2040C requires CS1101s in order for me to do it. However there was no error. Perhaps there could be a warning telling me that I am adding a 2K mod and there is pre-req for it

Actual Result: Allows me to add it in.

Screenshot:

image.png

[original: nus-cs2113-AY2324S2/pe-interim#2312] [original labels: type.FeatureFlaw severity.High]

ThawTunZan commented 5 months ago

Team's Response

These requirements are varied and depend very much on the particular modules you are taking. This means that we not only need to have the database access to every single modules in NUS but also the specific information in the module. Hence, it is more feasible if the choice is left to the user to make. It has also been mentioned that the users have to be aware of the prerequisites of the modules before adding them as seen in the screenshot below.

image.png

Duplicate status (if any):

--