nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Logging reps and sets #2104

Open nus-pe-bot opened 4 months ago

nus-pe-bot commented 4 months ago

You have added a check for the number of weights and number of sets. But you have not added a check for the number of sets and number of reps. You can do the same.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#1879] [original labels: type.FunctionalityBug severity.Medium]

joshualeejunyi commented 4 months ago

Team's Response

We allow logging of 0 reps as some exercises (such as planks) do not have specific rep count. Hence, only negative reps are rejected by the system.

Duplicate status (if any):

--