nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

DG Flowchart Error #2426

Open nus-pe-bot opened 2 months ago

nus-pe-bot commented 2 months ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


截屏2024-04-19 下午5.23.46.png In the stage "Is quit?" part , the branch of "No" connect to wrong stage.

For example, even if current group is deleted, it won't get group name from user. Instead, it will automatically switch to the next group in the group list as such:

截屏2024-04-19 下午5.27.35.png

This is mismatched with the program and might lead to misunderstanding. It should add new condition in the flowchart or it should change the line connection.


[original: nus-cs2113-AY2324S2/pe-interim#2335] [original labels: severity.Medium type.DocumentationBug]

1simjustin commented 2 months ago

Team's Response

This issue is rejected. The flowchart links to the conditional check of if there is a group. It automatically switches to the next group as other groups DO exist, which means that it fulfills the condition "yes", which is why it does not get group name from the user (which falls under the "no" condition), and instead proceeds to initialise the storage handler (for the switched-to group) which is part of the process of switching groups.

Duplicate status (if any):

--