nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Accepts regex metacharacters as name that interferes with save #2529

Open nus-pe-bot opened 4 weeks ago

nus-pe-bot commented 4 weeks ago

Bot accepts | as name input resulting in it breaking when running certain features on subsequent uses:

Furthermore, the UG states: "If Flirt & Fork encounters difficulty in generating an itinerary due to overly unique preferences or other issues, you will receive a message encouraging you to adjust your preferences or try another command. By using the smart command, you can discover new and exciting ways to enjoy your day, tailored specifically to what you love."

However the error message has no mention of how to adjust said preferences, and only informs the user to try itinerary. The user may be permanently unable to use the smart option as a result.

C:\Users\L5Z\Downloads\files-for-pe>java -jar test.jar
____________________________________________________________
Hungry for love? You've come to the right place.
Welcome to Flirt and Fork - where Cupid meets the chef!

If you ever feel lost, just type 'help' for a guiding star!
____________________________________________________________
me
Please enter your name:
bob | 0 |
Name cannot contain numbers. Please re-enter without numbers.
bob | hi
Great! Hello there bob | hi, it's my pleasure to know you!
____________________________________________________________
Please enter your age:
20
Wow, you're 20 years young! This might be handy information.
____________________________________________________________
Please enter your gender(Male/Female/Other):
Male
I see you're a Male!
____________________________________________________________
Where do you stay?

E: East
W: West
C: Central
S: South
NE: NorthEast
E
Thanks! Don't worry, I won't let the rest know where you stay ;)!
____________________________________________________________
What is your favourite cuisine?

W: Western
F: Fusion
J: Japanese
C: Chinese
T: Thai
K: Korean
I: Italian
S: Spanish
W
Thanks, this will be useful...
____________________________________________________________
Please enter your relationship status:

Enter 'M' if you are Married
Enter 'R' if you are in a serious relationship
Enter 'F' if you are having a fling
Enter 'D' if you are dating/testing the waters
Enter 'S' if you are single and ready to mingle
Enter 'X' if you are single and only looking to hangout with friends
S
Thanks for letting me know your relationship status! :)
____________________________________________________________
User details saved successfully!
Curious about what you can do? Just type 'help' for a sprinkle of tips!
____________________________________________________________
____________________________________________________________
exit
Love, like a good meal, is all about timing.
Keep your love simmering and your fork ready, see you at the next course!
____________________________________________________________

C:\Users\L5Z\Downloads\files-for-pe>java -jar test.jar
____________________________________________________________
Hungry for love? You've come to the right place.
Welcome to Flirt and Fork - where Cupid meets the chef!

If you ever feel lost, just type 'help' for a guiding star!

Remember, your anniversary is on W :)
____________________________________________________________
smart
I could not generate a suitable itinerary based on your personal details!
I'm not smart enough for your default preferences, try 'itinerary' command instead!
____________________________________________________________
itinerary
Oh no! The task description is empty.
____________________________________________________________

[original: nus-cs2113-AY2324S2/pe-interim#2501] [original labels: type.FunctionalityBug severity.High]

soongensayo commented 4 weeks ago

Team's Response

Thanks for letting us know! We agree, but we also did not handle that because no one has the character "|" in their names.

Duplicate status (if any):

--