nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

unclear exception message for updating cost of grocery #502

Open nus-se-script opened 6 months ago

nus-se-script commented 6 months ago

Input typed in

cost kailan $-1000

expected output

exception thrown to say negative number not allowed

actual output

Furthermore Ug claimed that PRICE can be any numerical value. -1000 is a numerical value but it was not accepted. Hence I have classified it a functionality bug

_{[original: nus-cs2113-AY2324S2/pe-interim#572] [original labels: type.FunctionalityBug severity.VeryLow]}

64-1 commented 6 months ago

Team's Response

In the UG, it says that the price must be a valid numerical value which is implied to be positive since the price is always positive. And unclear error message should be feature flaw and not functionality bugs as the program can run perfectly fine, the program gracefully rejected the negative value. We believe that this bug is not in scope as although the error message can be clearer, there is not issue with the program right now and the current error message is not wrong as a negative cost is quite obvious to be invalid.