search

nus-cs2113-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Inaccurate sequence diagram #538

Open nus-se-script opened 6 months ago

nus-se-script commented 6 months ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

For the sequence diagram detailing user authentication, it shows that an ExceededAttemptsException is created every time although this is not the case if the user logs in successfully. image.png

Perhaps a loop could be shown or some other path that shows the exception is only created when the condition of 3 exceeded attempts is met.

image.png

[original: nus-cs2113-AY2324S2/pe-interim#474] [original labels: severity.Medium type.DocumentationBug]

dylansiew commented 6 months ago

Team's Response

Thank you for pointing this out, we agree that a loop sequence diagram should've been used

Duplicate status (if any):

--