nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Sequence Diagram has multiple return arrows for one function call. #133

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

image.png

In the sequence diagram shown above, several function calls have multiple return "dotted" arrows, which is incorrect by convention.

Example 1:

image.png

In the above image, the developers are trying to show that the showCommandSuccessMessage() call causes a success message to be printed to the user by the Ui, before returning to the Command class. However, a dotted arrow is used to indicate the success message is being printed to the Ui. Suggestion: Instead of a dotted arrow, perhaps a comment box could be placed inside the activation box to indicate that the success message is being printed instead.

Example 2:

image.png

Similar to the first example, developers are trying to show that the showErrorMessage() function call causes an exception message to be printed to the user by the Ui. Perhaps a comment box (like above) could be used to indicate the exception message being printed instead.


[original: nus-cs2113-AY2425S1/pe-interim#247] [original labels: severity.Low type.DocumentationBug]

sarahchow03 commented 2 weeks ago

Team's Response

The team believes that this is a matter of non-standard notation, rather than an incorrect notation (ie. not defined by the course textbook). Based just on the method calls in this diagram, the arrows are correct, as the user is just another entity. We have also lowered the severity as it does not hinder understanding.

Duplicate status (if any):

--