search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Duplicate phone number is not detected #185

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Reproduce by:

  1. add n/Jonny ic/S1111111A p/91234567 v/10-10-2021 14:42
  2. add n/Jonny ic/S1111112A p/91234567 v/10-10-2021 14:42

Only the ic number is different. All else is same and this is not detected.

Screenshot 2024-11-15 at 5.29.02 PM.png

[original: nus-cs2113-AY2425S1/pe-interim#47] [original labels: severity.Medium type.FeatureFlaw]

kaboomzxc commented 1 week ago

Team's Response

Hi Tester, Thank you for your Description of Issue and Feedback.

This could be a useful enhancement but is not critical in this iteration. The crucial guard is against duplicate NRIC which we have implemented.

Furthermore, (while this scenario is a rare edge case, but a valid edge case nonetheless), it could be possible that the patient with the NRIC S1111111A changed phone number but he hasn't called in to the clinic to inform their updated phone number. The telecommunication company reuses phone numbers, and it is possible that the patient with the NRIC S1111112A got the same phone number and visited the clinic.

Duplicate status (if any):

--