search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Incorrect error message when start index is greater than end index #225

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Description: The description is confusing, and may be incorrect, as my start index that I have written is 4. Despite that, 4 is indeed not smaller than 3.

Expected: Error: Start index should be smaller than or equal to the end index

image.png

[original: nus-cs2113-AY2425S1/pe-interim#390] [original labels: severity.Medium type.FeatureFlaw]

lucas-sc0 commented 1 week ago

Team's Response

Thank you for pointing this out to us!

According to the definition of a very low severity category: "A flaw that is purely cosmetic and does not affect usage. In the docs or the UI that doesn't affect usage"

We sincerly feel that this should be classified as very low severity as it is a typo in UI as we mistakenly mis-ordered the printing of the start and end index for the error message!

To further justify, it did not allow user to perform this invalid action. And although the error message might be slightly erroneous because of typo, user gets the idea of what the error is, so intuitively user will know that Inventra does not allow the start index to be greater than end index.

Duplicate status (if any):

--