nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Improper Handling of Error when handling Corrupted File #288

Open nus-pe-bot opened 1 day ago

nus-pe-bot commented 1 day ago

image.png

In this case I have added my phone number wrongly in the first line, Name: james | NRIC: X9123457A | Phone Number: 8123456 | Date_Of_Birth: | Home Address: | Allergy: [] | Sex: | Medical History: [] | Visit: [21-10-2024 15:38, Diagnosis: [], Medications: []];

Program does not tell me where I am wrong (line number, or even which entry is wrong), and forces me to delete the whole file, or read line by line to find my own mistake

Is a high severity as the data of a General Practitioner clinic will be very big and the doctor should not need to re-enter every patient's details if 1 of it is edited wrongly

Same type of error if input for date (wrong formatting too), NRIC and other parameters

I realised program does not even tell you which file is wrong ("bookbob_appointment.txt" or "bookbob_data.txt"), all users would have to delete both files if they are not able to find out which line is entered incorrectly


[original: nus-cs2113-AY2425S1/pe-interim#483] [original labels: type.FunctionalityBug severity.High]

kaboomzxc commented 15 hours ago

Team's Response

Hi Tester, Thank you for your Description of Issue and Feedback.

reasonable points.

However, a normal clinician will not manually edit the data file. We have already given a caveat in DG to not manually modify data file contents:

image.png Hence, this will only cause minor inconvenience to some users who choose to disregard the caveat and manually modify the file contents (we think that the severity is medium).

We have already handled the edge case of data corruption errors.

However, we do agree with you to some extent that there could be much stronger/powerful detection and guidance for data file corruption errors.

Duplicate status (if any):

--