search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

system cant handle foreign numbers #304

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

the system should be able to handle foreign numbers - seeing as the product is targeted towards people interested in car rental, there is all the more reason to cater to the masses. most people who rent a car are visiting the nation, hence do not have a local phone number.

moreover, there are many reasons for a person living in singapore to have a foreign number (eg- whatsapp only, etc)

the system should be more accommodating and allow for users to be from all backgrounds - thus, the constraint of 8 digits could be removed, and '+' should be allowed to put country code, in my opinion.

Screenshot 2024-11-15 at 17.34.03.png

Screenshot 2024-11-15 at 17.34.09.png

[original: nus-cs2113-AY2425S1/pe-interim#64] [original labels: type.FeatureFlaw severity.High]

rexkoh425 commented 6 days ago

Team's Response

Thank you for the suggestion. We had previously considered that different countries have different regulations like driver's age , we decided to limit our application towards singaporeans thus our add-user command limits age to 18 which is the minimum driver's age and contact number to the format of 8 digits and starting with 8 or 9.

The value of adding foreign numbers does not add significant value in the context of singapore since extremely high percentage of singaporeans/foriengers have a singapore sim card. Furthermore ,having foreign number would definitely require more implementation like considering the age limits according to the phone number given and having to store a database of valid country codes and corresponding age limits. Since it requires significant more implementation work, this improvement is currently not under the scope of v2.1 and could be considered in future iterations.

Related requirements for Response.NotInScope according to website:

Requirement : The user cannot attempt to use the missing feature or when the user does so, the software fails gracefully, possibly with a suitable error message i.e., the software should not crash.

Reponse : Software blocks user from inputting commands other than the specified format and does not crash the program. When the user tries to add country code to the number , it would return a related error message.

Downgrading to Low : it does not affect functionality of the app and does not cause significant inconvience to our users given the minority of users which we are tryna improve on.

Duplicate status (if any):

--