nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Absence in check of pipeline characters for add_command #306

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

image.png Input: add_student i/A2134567A n/john | doe

Even though UG stated that there should not be any '|' character in the description (which is also not clear what you meant by descriptions, but I assume its the name of student), there should be a check by the program to tell users that it is not allowed. Otherwise, during the next session, characters after the pipeline will be wiped.

image.png Input: list_student


[original: nus-cs2113-AY2425S1/pe-interim#509] [original labels: type.FeatureFlaw severity.Low]

yeekian commented 1 week ago

Team's Response

The "|" delimiter is restricted for our use of Regex and storage, this symbol was selected to be the restricted symbol due to its infrequent use in common language, especially when it comes to the descriptions required, e.g. component names, student names, and grades, etc.

Additionally, the value at which regex gives to the extraction of arguments outweighs the small potential damage that this rare input will bring. It is alright to delay the rectification of this issue to future iterations.

As it is clearly stated in the UG to avoid the symbol, as it is not supported, the issue will be marked as not in scope.

Untitled.jpg

Duplicate status (if any):

--