search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Transactions that do not exist in reality can also be deleted. #464

Open nus-pe-bot opened 3 days ago

nus-pe-bot commented 3 days ago

Description When the user enters remove-all-txs after no previous transactions have been performed, there is no message that the transaction cannot be deleted because there are currently no transactions that can be deleted. Instead, the message to remove the transaction is still executed. This might mislead the user that there was a previous transaction and it has been deleted by him?

Steps to Reproduce What would you like to do?

list-txs No transaction available.

What would you like to do?

remove-all-txs All transactions removed!!!

Expected Behavior Cannot be deleted as there are no current transactions.

Actual Behavior All transactions removed!!!

Evidence image.png

[original: nus-cs2113-AY2425S1/pe-interim#737] [original labels: type.FeatureFlaw severity.Low]

tkhahns commented 1 day ago

Team's Response

We believe that this is a 50-50 option. When nothing exists, clearing everything or clearing nothing is the same. So choosing which to output in this case is very based on preference. We believe that it is purely based on your preference that you really want us to output "nothing to be cleared" in this case.

Duplicate status (if any):

--