nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Extreme dates are permitted when adding or editing patients/patient visits using "add"/"addVisit" and "edit"/"editVisit" #475

Open nus-pe-bot opened 1 day ago

nus-pe-bot commented 1 day ago

image.png

image.png

image.png

image.png

Currently patients/visits can be added to the registry with extreme visit date-times that are unreasonably distant in the past (i.e. adding a patient who "visited" on 01-01-0001 10:10).

While this doesn't currently disrupt any other functionality in the program, and can be corrected via the "edit" command, given the program's intended use-case in a clinic it does allow for potentially consequential user-error by practitioners across the program that might result in severe run-on-consequences in a real-life scenario (i.e. medical documentation).

This risk is not mentioned in the user guide, and thus I think practitioners expecting more safeguards surrounding data input may be especially at risk of making such mistakes.

In order to mitigate this risk, it may be useful to implement a limiting date in the past that cannot be exceeded when inputting dates, or at least a confirmation screen that explains the extremity of the user input.


[original: nus-cs2113-AY2425S1/pe-interim#755] [original labels: type.FeatureFlaw severity.Low]

kaboomzxc commented 1 day ago

Team's Response

Hi Tester, Thank you for your Description of Issue and Feedback.

after considering, we feel we could have implemented this guard against unreasonably distant past dates.

Duplicate status (if any):

--