nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Unnecessary validation when renting a car #479

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

One customer cannot rent two cars in this system, which is not practical in reality. And this case will show the same error message as the case where the user tries to rent an unavailable car.

Perhaps it is possible to distinguish between these two situations?

image.png


[original: nus-cs2113-AY2425S1/pe-interim#763] [original labels: severity.Low type.FunctionalityBug]

AaronZZ10 commented 1 week ago

Team's Response

A user can further book, or a car can be further booked when the transaction relating to that one user or that one car is marked done or removed. This is too ensure the logic of car and user management for car rental companies.

You can refer to practical applications like Grab. For Grab Advance Booking, when you book a ride beforehand, you cannot book another ride if you haven't completed your current ride.

We built this constraint to make sure the car rental functions in real life, if we allow users to make multiple bookings, some people will argue otherwise.

Duplicate status (if any):

--