search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Invalid parameters are not specified properly and user do not know what is wrong #494

Open nus-pe-bot opened 6 days ago

nus-pe-bot commented 6 days ago

image.png

Steps to reproduce 1)add-expense ChiCha a/ 17 d/ 2024-07-09 c/ FnB 2) type yes if needed 3) history /f 1985-11-01 /t 2000-11-11

The dates are correctly formatted , just that instead of f/ , /f is used. Same for t/ as well. They seem to be treated as blanks and it was not shown that parameters are wrong instead. This is confusing to me as i was wondering if it was a problem with the filter code instead. This might reduce usefulness to the user if they thought it was just a bug in the code and treat the feature is ineffective.

[original: nus-cs2113-AY2425S1/pe-interim#121] [original labels: type.FeatureFlaw severity.Low]

DanLinhHuynh-Niwashi commented 5 days ago

Team's Response

Thank you for the report, in this case the "/d" is not considered a keyword but a random string follow after the command, so we didn't take it into account this paramether, as "the extraneous parameters for commands that do not take in parameters will be ignored" (e.g. the history command may not take in parameter) as per the UG.

Duplicate status (if any):

--