search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Able to crash the program with water log #620

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

I was able to crash the program while adhering to the rule of the UG, the json cant handle a null day name so when i create a day with the name null it crashes

image.png

the program can be crashed by the following method

delete water /w 1 /t 01-02-2024 (the date here shoudnt exist)

history list

bye

then if you try to open the program it will crash the program

[original: nus-cs2113-AY2425S1/pe-interim#407] [original labels: type.FunctionalityBug severity.High]

TVageesan commented 6 days ago

Team's Response

This is a duplicate issue of #510 as it falls onto the same root cause that History is unable to save the JSON if any of its fields are missing or empty.

Duplicate status (if any):

Duplicate of #510