search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

loading data does not skip corrupted line as specified in UG #652

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

image.png

I change the description to some invisible string

image.png

It cannot load any data and deleted all data from stored file.

[original: nus-cs2113-AY2425S1/pe-interim#482] [original labels: type.FunctionalityBug severity.High]

Alfred-Goh02 commented 1 week ago

Team's Response

image.png This is taken from the course website from guidelines on bug triaging. While it is true that we did not account for invisible strings to completely corrupt the data file, this behaviour happens clearly because it is a deliberate input rather than one that users might face in everyday use. In the first place, editing storage file is only for advanced users, which are a small part of the main user base. Additionally, storage line verifications works accordingly with normal strings, which has been put in place in case advanced users saved the data file in the wrong format or made a mistake while editing it. Why would any users, advanced or general, be inputting invisible strings in our storage file? It can never be entered by mistake and this input is clearly deliberate and will not happen in users day to day use, if their purpose was to use the app as intended instead of sabotaging it.

image.png

According to the screenshot above, the program will show the lines ignored.

image.png We also did our own testing with invisible strings which also uses LRM (Unicode: U+200E) and there was no such error, could you provide the exact invisible string input for testing purposes?

Duplicate status (if any):

--