search

nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Data Corruption if using Japanese as the Manga/Author Name #662

Open nus-pe-bot opened 2 days ago

nus-pe-bot commented 2 days ago

Since this is a Manga Tantou (漫画担当), I think it would be nice if you could support using Japanese as the actual Manga/Author name. I tried to manually edit the data file as follows:

image.png

And then start a new session:

image.png

It seems that the Kanji character corrupts, and the program cannot identify the name of the author.

You could consider add support for Japanese characters, and I believe if you do so, Chinese/Korean characters will be simutaneously supported by your project. Otherwise, you could consider adding "Latin languages support only" in your UG.

Follow up: I found that if I didn't touch file editing, the program can well support Japanese/Chinese/Korean characters. So maybe it's something to do with the encoding method of your data saving function or something wrong with my environment. Please kindly check on that.

[original: nus-cs2113-AY2425S1/pe-interim#508] [original labels: type.FeatureFlaw severity.Low]

xenthm commented 1 day ago

Team's Response

Upon further clarification with Prof. on MS Teams, we found that this issue, while valid in a vacuum, should not be considered a valid bug within the context of this course. A screenshot of the conversation is provided below.

image.png

Duplicate status (if any):

--