nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

File corrupted when using expense manager #774

Open nus-pe-bot opened 18 hours ago

nus-pe-bot commented 18 hours ago

I did not tamper with the save file manually ... but somehow it got messed up ?

image.png

What I had done before:

image.png

image.png

Reloading the program as instructed does not fix it either :(

image.png

Now the recurring expense is also part of the normal list:

image.png

This is the save file for more info:

image.png


[original: nus-cs2113-AY2425S1/pe-interim#413] [original labels: type.FunctionalityBug severity.High]

C2linaung commented 7 hours ago

Team's Response

Thank you for pointing this bug out. I have tried my best to replicate the error, but unfortunately I can't reproduce it even after multiple tries. I did exactly the same commands that have been provided in the screenshot (see pictures below as proof).

Additionally, even if the bug was present, it at most justifies as a Medium for the following reason:

  1. Issues related to corrupted files has been handled and the program does not stop running (ie. all other functionalities would have worked as per normal even with the error message showing).
  2. If the file was corrupted in some way, you could have reverted to the previous state of backup using the '/b/' command and '/r/' command. As stated in the UG, this is to protect all the data that has been stored
  3. Alternatively, you could also follow the instructions given by the application and see the line in which the error occurred in and change it yourself.

As pointed in the 3 reasons, the severity does not justify a high but rather a MEDIUM and that is ONLY IF the bug could even be replicated.

To make sure that I really couldn't reproduce this bug, I have also tried the following to see if the bug surfaces:

  1. Open the expense file and run all the code again. Same thing no issue
  2. Open the expense file and corrupt the data manually. Expected error showed up, removed the error from the file and everything works fine again.

Proof of trying to reproduce the bug: response 1 .png

response 2.png

response 3.png

response 4.png

Duplicate status (if any):

--