Google's code review checks for three aspects: correctness and comprehension, appropriateness for codebase, and readability and code consistency.
Can have one reviewer for all three aspects, or split the aspects up to multiple reviewers
Code review has many benefits and not just checking for code correctness and comprehensibility.
Eg knowledge sharing between author and reviewer, consistency across codebase and a historical record of code review
Best practices include being polite and professional, writing small changes, and automating where possible (eg linters, static analysis)
Relevance to CATcher / actually all the NUS-OSS projects:
Encourage small PRs (Google defines small as <200 lines)
Get junior devs to review code correctness and comprehension and senior devs to review code appropriateness and readability - frees up capacity for senior devs + allows junior devs to learn by peer-review
Share knowledge during code reviews - can give helpful FYI comments if possible.
Book: SE@Google Chapter 14: Code Review
Summary:
Relevance to CATcher / actually all the NUS-OSS projects: