clean up StudentsLogicTest

[damithc]

From QiaoLian...@gmail.com on September 18, 2013 15:42:43

go through and fix TODOs

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1195

[damithc]

From QiaoLian...@gmail.com on September 18, 2013 19:17:06

https://codereview.appspot.com/13241055/

Status: ReadyForReview

[damithc]

From dam...@gmail.com on September 18, 2013 23:39:11

Qiao Liang, use the EclEmma plugin to check coverage. See if the Test class has sufficient coverage of the class under test.

Status: ChangesRequested

[damithc]

From QiaoLian...@gmail.com on September 24, 2013 21:15:32

https://codereview.appspot.com/13891044/ all covered except 2 methods about sending emails

Status: ReadyForReview

[damithc]

From dam...@gmail.com on September 24, 2013 21:42:11

Status: ReadyToMerge

[damithc]

From dam...@gmail.com on September 26, 2013 19:36:35

This issue was updated by revision 287c60a8b8ec .

[damithc]

From dam...@gmail.com on September 26, 2013 19:36:37

This issue was updated by revision d6f594be7c8e .

[damithc]

From dam...@gmail.com on September 26, 2013 20:15:04

Failing tests. Check more carefully before uploading next time.

Status: ChangesRequested

[damithc]

From QiaoLian...@gmail.com on October 01, 2013 01:41:19

Is this referring to Issue1212 : studentsDbTest? I run the test again and it's still 4 failing cases, which we have seen before.

Attachment: Screen Shot 2013-10-01 at 4.38.14 PM.png

[damithc]

From dam...@gmail.com on October 01, 2013 01:46:36

No, this one kept failing last time. I'll try again and let you know.

[damithc]

From dam...@gmail.com on October 11, 2013 23:25:57

Still failing. I ran the 'component tests' only and this test keeps failing.

teammates.common.exception.EnrollException:

Problem in line : t2|n8|e8@g|c t2|n9|e9@g|c

t2|n10|e10@g|c
• Enroll line had too many parts

at teammates.logic.core.StudentsLogic.enrollStudents(StudentsLogic.java:205) at teammates.test.cases.logic.StudentsLogicTest.testEnrollStudent(StudentsLogicTest.java:153) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84) at org.testng.internal.Invoker.invokeMethod(Invoker.java:714) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) at org.testng.TestRunner.privateRun(TestRunner.java:767) at org.testng.TestRunner.run(TestRunner.java:617) at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at org.testng.SuiteRunner.access$000(SuiteRunner.java:37) at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368) at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722)

[damithc]

From QiaoLian...@gmail.com on October 22, 2013 06:53:26

this test case ?

Status: ReadyForReview

Attachment: Screen Shot 2013-10-22 at 9.42.57 PM.png

[damithc]

From dam...@gmail.com on October 22, 2013 07:08:54

according to the stack trace, it is teammates.test.cases.logic.StudentsLogicTest.testEnrollStudent

[damithc]

From dam...@gmail.com on October 23, 2013 00:10:42

Status: ChangesRequested

[damithc]

From QiaoLian...@gmail.com on November 06, 2013 00:27:07

still cannot reproduce failing test case https://codereview.appspot.com/22340043

Status: ReadyForReview

[damithc]

From dam...@gmail.com on November 07, 2013 02:02:22

Status: ReadyToMerge

[damithc]

From dam...@gmail.com on November 08, 2013 21:04:02

This one still fails. I think there is a state leak between tests and the order in which tests run matters. The order used in your comp could be different from mine. Try to run tests and see if that is the case. You can force a particular order like this. @Test void allTests(){ test1(); test2(); }

Status: ChangesRequested

[damithc]

From dam...@gmail.com on January 26, 2014 21:18:59

Seem no longer failing.

Status: Invalid

[damithc]

From QiaoLian...@gmail.com on January 27, 2014 09:53:44

But the old code has not merged yet.

[damithc]

From dam...@gmail.com on January 27, 2014 17:58:52

Ah yes, that's why. This is what happens when you sit on an issue for too long. :-p

Status: Started

[damithc]

From dam...@gmail.com on January 27, 2014 17:59:06

Status: ChangesRequested

[damithc]

From QiaoLian...@gmail.com on January 27, 2014 18:50:34

Really sorry and no excuse about that >.< Still trying to catch up.

Referring to the possible association of failing test with the order of running it: " @Test void allTests(){ test1(); test2(); }

" Could you give a example(testing orders) where it fails? I tried "All tests" and it's still not failing.

[damithc]

From dam...@gmail.com on February 26, 2014 01:56:24

This issue was updated by revision 287c60a8b8ec .

[damithc]

From dam...@gmail.com on February 26, 2014 01:56:25

This issue was updated by revision d6f594be7c8e .