Improve formatting in help pages

[damithc]

From dam...@gmail.com on January 15, 2014 15:56:29

css need to be tweaked. The current format is not very readable.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1511

[damithc]

From wulifu20...@gmail.com on February 05, 2014 02:14:08

can i fix it?

Cc: arnold.k...@gmail.com

[damithc]

From arnold.k...@gmail.com on February 05, 2014 02:42:39

Go ahead. Make necessary changes as you think appropriate. There's two things that's especially jarring though: 1) text too compact (line spacing). 2) lists don't show bullet points.

post screenshots afterwards :)

Owner: wulifu20...@gmail.com

[damithc]

From arnold.k...@gmail.com on February 05, 2014 23:27:42

Labels: -Difficulty-Medium Difficulty-Low

[damithc]

From wulifu20...@gmail.com on February 12, 2014 02:44:32

Status: Started

[damithc]

From wulifu20...@gmail.com on February 12, 2014 03:19:15

https://codereview.appspot.com/53760046/

Status: ReadyForReview

Attachment: Screen Shot 2014-02-12 at 7.18.05 pm.png

[damithc]

From wulifu20...@gmail.com on February 12, 2014 03:38:05

link to staging server: https://4-18-dot-teammates-lifu.appspot.com/ (I've added you as instructor, if there is anything wrong pls let me know)

Cc: -arnold.k...@gmail.com dam...@gmail.com

[damithc]

From arnold.k...@gmail.com on February 12, 2014 05:20:42

As mentioned during meeting

Status: ChangesRequested

[damithc]

From wulifu20...@gmail.com on February 12, 2014 06:20:01

https://codereview.appspot.com/53760046/ link to staging server: https://4-18-dot-teammates-lifu.appspot.com/

Status: ReadyForReview
Cc: arnold.k...@gmail.com

[damithc]

From arnold.k...@gmail.com on February 12, 2014 18:37:54

Hi Lifu,

In general try to use CSS instead of doing inline styles in the html as it will be harder to maintain if the styles are scattered throughout the html(don't modify what's already in common.css as you might affect other pages but you can add stuff in it or make a new css for the help pages).

Specific places that can be improved (see attached pictures): instr1: There's two different fonts here? Try to make the fonts used consistent. Also, the bottom list should be bulleted also.

instr2: Indent the content of each section in to make it clearer.

instr3: The list should be indented in. Also, the Tips for using the system link is in a different font? Check other links in the page and make sure the fonts are consistent also.

instr4: The heading "Standard team peer evaluation session with fixed questions " and "2. Feedback session with customizable questions" should be made for prominent. Maybe put it inside h2/3 tag? See which is more appropriate

Attachment: instr1.png instr2.png instr3.png instr4.png

[damithc]

From arnold.k...@gmail.com on February 12, 2014 18:38:09

Status: ChangesRequested

[damithc]

From wulifu20...@gmail.com on February 28, 2014 07:18:06

Hi Arnold, Sorry for delaying the issue for so long. I've just fixed the things you pointed out in your instruction but there are something about instr2 that I need to ask for your clarification I've tried putting the contents into a div and set the padding to indent it, as shown in the picture, is it what you are looking for?

Cc: -dam...@gmail.com

Attachment: indent paragraph.png

[damithc]

From arnold.k...@gmail.com on February 28, 2014 20:05:14

Yes, that's what I meant. Also indent all the sections below the two you indented (Enroll students, etc).

By the way The heading "Enrol students" should be "Enroll students", can you fix that too?

[damithc]

From wulifu20...@gmail.com on March 01, 2014 06:37:31

https://codereview.appspot.com/53760046/ link to staging server: https://4-18-dot-teammates-lifu.appspot.com/ below are the snapshots note that for your instr1 I've looked into it but found no difference in their font type, so I didn't make any change

Status: ReadyForReview

Attachment: instr1.png instr2.png instr3.png instr4.png

[damithc]

From arnold.k...@gmail.com on March 02, 2014 19:09:08

added comments at the review site

Good job for the changes requested. There's some more things that can be improved though.

For instr4 (session type section), the list shouldn't be bulleted if it is already numbered. You can change the unordered list into an ordered one if you want to keep the numbering?

For the FAQ section and the Tips section, the list's left-side is outside the header's left-side (see screenshot). Try to make the list to be inside the header, horizontal alignment-wise.

The student FAQ section looks very different from the instructor one? Try to make the two pages look consistent.

Status: ChangesRequested

Attachment: faq.png

[damithc]

From wulifu20...@gmail.com on March 02, 2014 21:03:58

https://codereview.appspot.com/53760046/ link to staging server: https://4-18-dot-teammates-lifu.appspot.com/ below are the snapshots

Status: ReadyForReview

Attachment: bullet point with number.png content inside header.png

[damithc]

From arnold.k...@gmail.com on March 02, 2014 21:20:07

Added minor comments to the review site.

Prof, do you have other comments for this one?

Status: ChangesRequested
Cc: dam...@gmail.com

[damithc]

From dam...@gmail.com on March 02, 2014 22:08:32

No other comments from me.

[damithc]

From wulifu20...@gmail.com on March 03, 2014 01:04:14

finish formatting css https://codereview.appspot.com/53760046/ link to staging server: https://4-18-dot-teammates-lifu.appspot.com/

Status: ReadyForReview
Cc: -dam...@gmail.com

[damithc]

From arnold.k...@gmail.com on March 03, 2014 18:15:10

Status: ReadyToMerge

[damithc]

From arnold.k...@gmail.com on March 03, 2014 21:04:48

Status: MergeInProgress

[damithc]

From arnold.k...@gmail.com on March 03, 2014 21:40:54

This issue was updated by revision 8faf5a9c3e60 .

Status: Delivered

[damithc]

From dam...@gmail.com on March 07, 2014 21:40:26

Status: Deployed
Labels: Milestone-V4.90