search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

FieldValidator: Increase the rule for input field validation checking #1622

Closed damithc closed 10 years ago

damithc commented 10 years ago

From OTS.Nexus on January 22, 2014 18:12:40

Increase the validation checking so that the front-end validation can be shifted to back-end

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1541

damithc commented 10 years ago

From OTS.Nexus on January 22, 2014 02:13:40

Status: Started

damithc commented 10 years ago

From OTS.Nexus on January 22, 2014 02:14:35

Blocking: teammatespes:1277

damithc commented 10 years ago

From OTS.Nexus on January 23, 2014 23:50:43

Currently the rules for checking valid name in front-end javascript are somehow inconsistent. Below are the examples:

Person name & institutional name: -allow letter, digits, slash(/), backslash(), fullstop(.), comma(,), apostrophe('), hyphen(-), round brackets, space and tab

Evaluation & feedback name: -allow only letters, digits and space

Course name & team name: -no restriction at all

So for now should we just follow the current validation from the front-end or should we come up with a better validation?

damithc commented 10 years ago

From OTS.Nexus on January 24, 2014 15:20:07

https://codereview.appspot.com/56790043/

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on January 24, 2014 22:49:33

Status: ChangesRequested

damithc commented 10 years ago

From OTS.Nexus on January 25, 2014 09:20:24

-Updated regex validation for name, rather than listing out all acceptable symbols, it specify invalid symbols (| and %) instead. -Added and updated test cases https://codereview.appspot.com/56790043/#ps70001

Summary: FieldValidator: Increase the rule for input field validation checking (was: FieldValidator: Increase the rule for validation checking)
Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on January 25, 2014 16:07:07

some comments added.

Status: ReadyToMerge

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 06:40:02

This issue was updated by revision 44be3aa860f8 .

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 06:45:00

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on January 30, 2014 04:42:14

Status: Deployed
Labels: Milestone-V4.84

damithc commented 10 years ago

From OTS.Nexus on February 26, 2014 01:58:34

This issue was updated by revision 44be3aa860f8 .