search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Better logging for join emails #1628

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on January 23, 2014 14:54:02

Something like: Join emails sent: account 1 : link sent account 2: link sent ...

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1547

damithc commented 10 years ago

From arnold.k...@gmail.com on January 23, 2014 00:00:24

Status: Started

damithc commented 10 years ago

From arnold.k...@gmail.com on January 23, 2014 18:31:51

https://codereview.appspot.com/56380043/

Status: ReadyForReview
Cc: dam...@gmail.com

Attachment: admin.png

damithc commented 10 years ago

From dam...@gmail.com on January 23, 2014 18:46:33

Key need not be bold. The word 'Registration key' is also not needed. However, this is not just about the Remind action. The more important ones are the emails sent automatically at the start, and near the closing.

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on January 23, 2014 20:39:55

Did the changes to EmailAction. Attached is the screenshots https://codereview.appspot.com/56380043/

Status: ReadyForReview

Attachment: admin_remind.png auto_closing_remind.png auto_feedback_closing_remind.png auto_feedback_opening_remind.png auto_opening_remind.png

damithc commented 10 years ago

From dam...@gmail.com on January 23, 2014 21:27:03

Looks good. Try to avoid having two lists. O

damithc commented 10 years ago

From arnold.k...@gmail.com on January 23, 2014 21:33:00

Two lists?

damithc commented 10 years ago

From dam...@gmail.com on January 23, 2014 21:44:35

In the log message, seems there's a list of recipients (without keys) followed by another list (with keys)

damithc commented 10 years ago

From arnold.k...@gmail.com on January 23, 2014 21:51:17

Oh, the ones without keys already joined and weren't sent keys. The ones with keys are those who hasn't joined and sent keys. They are actually not separated and is in sending order. I don't really differentiate what email it is and only check if there's a registration key in the mail body so itlooks like that. Should I sort them or something?

damithc commented 10 years ago

From dam...@gmail.com on January 23, 2014 22:07:34

No, it is fine as it is. Go ahead and merge.

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on January 23, 2014 23:06:33

This issue was updated by revision a7b7c3a8fbfa .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on January 24, 2014 20:43:47

Status: Deployed
Labels: Milestone-V4.83

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 01:58:31

This issue was updated by revision a7b7c3a8fbfa .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 02:50:58

Status: Deployed