search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

instructorHomePage: Introduce sorting feature for course #1639

Closed damithc closed 10 years ago

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 23:00:58

Allow user to sort courses to find specified course easier

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1559

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 09:43:33

Here is the implementation that I have come out with:

We will provide users the option to sort by course ID, course name, or creation date as shown below. The default sorting option is course ID (same as before). If user click at other sorting option, the page will reload and show the sorted list of courses.

Does this solution sound okay?

Attachment: sort.JPG

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 13:33:56

Dr Damith, I have added basic sorting feature as mentioned above. Currently it only supports ascending order sorting for course ID & course name, and descending order for course creation date. Can you have a look at it on my staging server? I have created an instructor account for you to access it. http://4-83-15-dot-teammates-ots.appspot.com/ Here are the codes: https://codereview.appspot.com/57120043/

Cc: dam...@gmail.com

damithc commented 10 years ago

From dam...@gmail.com on January 26, 2014 16:12:50

So far so good. Is it possible to move the 'Add New Course' link inside the new box used for sorting? (to reduce UI elements at the top of the page) The current sorting orders are enough.

damithc commented 10 years ago

From dam...@gmail.com on January 26, 2014 16:19:06

By the way, may be use creation time as the default sort order?

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 20:53:13

Okay. So currently no need to provide option to choose between ascending/descending order?

damithc commented 10 years ago

From dam...@gmail.com on January 26, 2014 20:59:07

Yes.

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 21:49:36

Which of the following would be a better way of combining both 'Add new course' link and sorting radio buttons?

Attachment: capture1.JPG capture2.JPG

damithc commented 10 years ago

From dam...@gmail.com on January 26, 2014 21:58:54

how about 2nd one, but use dark blue (or light blue) for the entire box?

damithc commented 10 years ago

From OTS.Nexus on January 26, 2014 22:20:58

Like this? I think light blue might be better since dark blue is used for boxes containing course detail, to represent different logical section.

Attachment: capture3.JPG

damithc commented 10 years ago

From dam...@gmail.com on January 26, 2014 22:37:37

Yeah, light blue is better. Can make it one line? May be sort options left-aligned and link right-aligned? Make sure the 'unclicked' color of the link is visible. The original link used white fonts.

damithc commented 10 years ago

From OTS.Nexus on January 27, 2014 07:35:29

Sort options are located in a table while the link is located in another div element initially. I put the link inside the table now and made some tweaks on css to make them apart.

Below are the snapshots showing the color before/after the link has been clicked. Should be okay right?

Attachment: unclicked.JPG clicked.JPG

damithc commented 10 years ago

From dam...@gmail.com on January 27, 2014 07:54:28

Yup, looks good.

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 19:06:16

Issue 1279 has been merged into this issue.

Cc: arnold.k...@gmail.com

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 19:07:33

Cc: -arnold.k...@gmail.com

damithc commented 10 years ago

From OTS.Nexus on January 30, 2014 14:13:53

Test cases added. https://codereview.appspot.com/58810043/

Labels: -Difficulty-Medium Difficulty-High

damithc commented 10 years ago

From OTS.Nexus on January 30, 2014 14:14:18

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on January 30, 2014 17:38:51

Status: ReadyToMerge

damithc commented 10 years ago

From OTS.Nexus on January 31, 2014 02:27:53

This issue was updated by revision 28d567fa8f51 .

damithc commented 10 years ago

From OTS.Nexus on January 31, 2014 02:52:02

Dr Damith, I have only run all the test on dev server but couldn't run it on staging server as I am using a very slow connection in Malaysia here, the long time taken to load a page causing the test to time out. So i couldn't make sure whether does everything work fine on staging server too..

Status: Delivered

damithc commented 10 years ago

From arnold.k...@gmail.com on February 06, 2014 00:52:52

Status: Deployed
Labels: Milestone-V4.85

damithc commented 10 years ago

From OTS.Nexus on February 26, 2014 01:58:37

This issue was updated by revision 28d567fa8f51 .