search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Remove references to registration key #1643

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on January 28, 2014 15:00:04

In line with the effort to make "join"ing transparent to users, some/all references to registration keys should be removed.

Two places where they can still be found is attached

Attachment: key_instructor.png key_student.png

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1566

damithc commented 10 years ago

From dam...@gmail.com on January 28, 2014 01:37:29

Yup, in both cases, we can use 'Join link' instead. In the first case, just give the text of the link instead of making it a hyper link. We don't want the instructor to click on the link.

Status: Accepted
Owner: arnold.k...@gmail.com

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 00:03:26

also the status message here: https://codereview.appspot.com/57660043/diff/20001/src/test/resources/pages/StudentHomeInvalidKey.html#newcode63

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 00:12:02

Prof, is this ok?

Status: Started
Cc: dam...@gmail.com

Attachment: Untitled picture.png

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 00:19:26

This one is the student detail page

Attachment: Untitled picture.png

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 00:32:31

And this is the google id is owned by another user message

Attachment: Untitled picture.png

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 00:58:37

LAstly the email generated when contact us is clicked (I use gmail to open mailto)

Attachment: Untitled picture.png

damithc commented 10 years ago

From dam...@gmail.com on January 29, 2014 01:52:09

"... belongs to a different user whose ..." The rest is ok.

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 19:02:12

https://codereview.appspot.com/58500044/

Summary: Remove references to registration key (was: Remove references to registration key?)
Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on January 29, 2014 19:19:26

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on January 29, 2014 19:33:45

This issue was updated by revision 2c82976c5e6d .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on January 30, 2014 04:42:14

Status: Deployed
Labels: Milestone-V4.84

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 01:58:37

This issue was updated by revision 2c82976c5e6d .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 02:50:58

Status: Deployed