search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Refine NUMSCALE question UI at InstructorFeedbackEdit #1650

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on February 03, 2014 10:41:01

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1575

damithc commented 10 years ago

From arnold.k...@gmail.com on February 06, 2014 00:00:59

The creation form to be edited is in instructorFeedbackEdit.jsp and feedbackQuestionNumScaleEditFormTemplate.html. instructorFeedbackEdit.js also need to be edited as the possible value line is generated there.

damithc commented 10 years ago

From arnold.k...@gmail.com on February 06, 2014 00:06:58

Xia Lu, do this one next. Make sure to update affected UI tests also. Do ask me if you need help with this.

Owner: Vivian.X...@gmail.com

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 06, 2014 18:54:31

Status: Started

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 13, 2014 22:17:06

https://codereview.appspot.com/63760043/

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on February 13, 2014 22:25:12

Xia Lu, how come there's a lot of setting and binary file modified?

damithc commented 10 years ago

From arnold.k...@gmail.com on February 13, 2014 22:32:25

Commented at review site. Have not checked the actual changes yet. However, unless absolutely necessary try not to change global settings and binary file as it might break other developer's setup. And if it is necessary to change some setting/binary please explain why.

Status: ChangesRequested

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 14, 2014 00:37:11

I think the binary file for google app engine is because I use a different version. I do not about others. I have reverted all the files affected.

Status: ReadyForReview

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 15, 2014 04:13:04

Cc: arnold.k...@gmail.com

damithc commented 10 years ago

From arnold.k...@gmail.com on February 16, 2014 23:32:45

Sorry, somehow the code review site says the patch is too large to download and I can't download it. Can you try uploading it again to a new issue? (i.e. without the -i option)

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 17, 2014 22:39:47

https://codereview.appspot.com/65090044/

damithc commented 10 years ago

From arnold.k...@gmail.com on February 17, 2014 22:50:28

Thanks, will review by today

damithc commented 10 years ago

From arnold.k...@gmail.com on February 17, 2014 23:58:34

Mostly good job! Some minor things to be fixed at review site.

Status: ChangesRequested

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 18, 2014 18:23:28

after I change possible values, the preview page looks a bit strange. There are no settings on that page, but the information below says: "based on above seetings: "

Attachment: D2031836-510A-42F6-AF94-9674A1B7D067.png

damithc commented 10 years ago

From arnold.k...@gmail.com on February 18, 2014 18:24:38

Hm? I think you changed the wrong one? Make sure you change the one for question edit form not submission form

damithc commented 10 years ago

From arnold.k...@gmail.com on February 18, 2014 18:31:24

This is what I'm talking about (see screenshot).

Actually, are they generated in the same function? In that case try to work around it with a boolean flag?

Attachment: Untitled picture.png

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 18, 2014 23:05:32

I have made the changes accordingly.

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on February 19, 2014 00:00:27

One more minor thing to make the code neater :)

Status: ChangesRequested

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 19, 2014 02:18:51

changes have been made.

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on February 19, 2014 18:13:51

The name clash is caused by the tooltip being put in the ParamName class not the Tooltips class. Do move it over otherwise it's not classified correctly.

Status: ChangesRequested

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 20, 2014 01:17:11

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on February 20, 2014 18:29:11

Status: ChangesRequested

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 21, 2014 02:39:53

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on February 21, 2014 17:34:48

This issue was updated by revision 9a4c950b3643 .

Status: Delivered

damithc commented 10 years ago

From arnold.k...@gmail.com on February 23, 2014 17:46:09

Status: New

damithc commented 10 years ago

From arnold.k...@gmail.com on February 23, 2014 17:52:17

Status: Deployed
Labels: Milestone-V4.88

damithc commented 10 years ago

From arnold.k...@gmail.com on February 23, 2014 17:56:36

Really sorry, I forgot to change the committer name when I committed the change. I've put a comment explaining that this commit is yours and you'll be creditted properly at all other places.

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 01:58:39

This issue was updated by revision 9a4c950b3643 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 02:48:48

Status: Deployed