nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Correct a small error in the regex used for name validation #1658

Closed damithc closed 10 years ago

damithc commented 10 years ago

From OTS.Nexus on February 05, 2014 16:42:32

Remove an extra closing brace in the regex

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1585

damithc commented 10 years ago

From OTS.Nexus on February 05, 2014 00:44:52

https://codereview.appspot.com/57290044/

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on February 05, 2014 01:37:50

Status: ChangesRequested

damithc commented 10 years ago

From OTS.Nexus on February 05, 2014 08:56:27

Added unit testing for regex validation on name https://codereview.appspot.com/57290044/#ps20002

Status: ReadyForReview
Labels: -Difficulty-Low Difficulty-Medium

damithc commented 10 years ago

From dam...@gmail.com on February 05, 2014 15:43:44

I was hoping for a method to test the regex on its own, not test the method that is using the regex. Still, it is ok.

Status: ReadyToMerge

damithc commented 10 years ago

From OTS.Nexus on February 06, 2014 05:10:38

This issue was updated by revision 507473143613 .

damithc commented 10 years ago

From OTS.Nexus on February 06, 2014 21:05:35

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on February 07, 2014 20:57:39

Status: Deployed
Labels: Milestone-V4.86

damithc commented 10 years ago

From OTS.Nexus on February 26, 2014 01:58:27

This issue was updated by revision 507473143613 .